123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899 |
- /**
- * @fileoverview Rule to flag when using constructor without parentheses
- * @author Ilya Volodin
- */
- "use strict";
- //------------------------------------------------------------------------------
- // Requirements
- //------------------------------------------------------------------------------
- const astUtils = require("./utils/ast-utils");
- //------------------------------------------------------------------------------
- // Helpers
- //------------------------------------------------------------------------------
- //------------------------------------------------------------------------------
- // Rule Definition
- //------------------------------------------------------------------------------
- /** @type {import('../shared/types').Rule} */
- module.exports = {
- meta: {
- type: "layout",
- docs: {
- description: "Enforce or disallow parentheses when invoking a constructor with no arguments",
- recommended: false,
- url: "https://eslint.org/docs/rules/new-parens"
- },
- fixable: "code",
- schema: {
- anyOf: [
- {
- type: "array",
- items: [
- {
- enum: ["always", "never"]
- }
- ],
- minItems: 0,
- maxItems: 1
- }
- ]
- },
- messages: {
- missing: "Missing '()' invoking a constructor.",
- unnecessary: "Unnecessary '()' invoking a constructor with no arguments."
- }
- },
- create(context) {
- const options = context.options;
- const always = options[0] !== "never"; // Default is always
- const sourceCode = context.getSourceCode();
- return {
- NewExpression(node) {
- if (node.arguments.length !== 0) {
- return; // if there are arguments, there have to be parens
- }
- const lastToken = sourceCode.getLastToken(node);
- const hasLastParen = lastToken && astUtils.isClosingParenToken(lastToken);
- // `hasParens` is true only if the new expression ends with its own parens, e.g., new new foo() does not end with its own parens
- const hasParens = hasLastParen &&
- astUtils.isOpeningParenToken(sourceCode.getTokenBefore(lastToken)) &&
- node.callee.range[1] < node.range[1];
- if (always) {
- if (!hasParens) {
- context.report({
- node,
- messageId: "missing",
- fix: fixer => fixer.insertTextAfter(node, "()")
- });
- }
- } else {
- if (hasParens) {
- context.report({
- node,
- messageId: "unnecessary",
- fix: fixer => [
- fixer.remove(sourceCode.getTokenBefore(lastToken)),
- fixer.remove(lastToken),
- fixer.insertTextBefore(node, "("),
- fixer.insertTextAfter(node, ")")
- ]
- });
- }
- }
- }
- };
- }
- };
|