123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637 |
- /**
- * @fileoverview Rule to enforce spacing before and after keywords.
- * @author Toru Nagashima
- */
- "use strict";
- //------------------------------------------------------------------------------
- // Requirements
- //------------------------------------------------------------------------------
- const astUtils = require("./utils/ast-utils"),
- keywords = require("./utils/keywords");
- //------------------------------------------------------------------------------
- // Constants
- //------------------------------------------------------------------------------
- const PREV_TOKEN = /^[)\]}>]$/u;
- const NEXT_TOKEN = /^(?:[([{<~!]|\+\+?|--?)$/u;
- const PREV_TOKEN_M = /^[)\]}>*]$/u;
- const NEXT_TOKEN_M = /^[{*]$/u;
- const TEMPLATE_OPEN_PAREN = /\$\{$/u;
- const TEMPLATE_CLOSE_PAREN = /^\}/u;
- const CHECK_TYPE = /^(?:JSXElement|RegularExpression|String|Template|PrivateIdentifier)$/u;
- const KEYS = keywords.concat(["as", "async", "await", "from", "get", "let", "of", "set", "yield"]);
- // check duplications.
- (function() {
- KEYS.sort();
- for (let i = 1; i < KEYS.length; ++i) {
- if (KEYS[i] === KEYS[i - 1]) {
- throw new Error(`Duplication was found in the keyword list: ${KEYS[i]}`);
- }
- }
- }());
- //------------------------------------------------------------------------------
- // Helpers
- //------------------------------------------------------------------------------
- /**
- * Checks whether or not a given token is a "Template" token ends with "${".
- * @param {Token} token A token to check.
- * @returns {boolean} `true` if the token is a "Template" token ends with "${".
- */
- function isOpenParenOfTemplate(token) {
- return token.type === "Template" && TEMPLATE_OPEN_PAREN.test(token.value);
- }
- /**
- * Checks whether or not a given token is a "Template" token starts with "}".
- * @param {Token} token A token to check.
- * @returns {boolean} `true` if the token is a "Template" token starts with "}".
- */
- function isCloseParenOfTemplate(token) {
- return token.type === "Template" && TEMPLATE_CLOSE_PAREN.test(token.value);
- }
- //------------------------------------------------------------------------------
- // Rule Definition
- //------------------------------------------------------------------------------
- /** @type {import('../shared/types').Rule} */
- module.exports = {
- meta: {
- type: "layout",
- docs: {
- description: "Enforce consistent spacing before and after keywords",
- recommended: false,
- url: "https://eslint.org/docs/rules/keyword-spacing"
- },
- fixable: "whitespace",
- schema: [
- {
- type: "object",
- properties: {
- before: { type: "boolean", default: true },
- after: { type: "boolean", default: true },
- overrides: {
- type: "object",
- properties: KEYS.reduce((retv, key) => {
- retv[key] = {
- type: "object",
- properties: {
- before: { type: "boolean" },
- after: { type: "boolean" }
- },
- additionalProperties: false
- };
- return retv;
- }, {}),
- additionalProperties: false
- }
- },
- additionalProperties: false
- }
- ],
- messages: {
- expectedBefore: "Expected space(s) before \"{{value}}\".",
- expectedAfter: "Expected space(s) after \"{{value}}\".",
- unexpectedBefore: "Unexpected space(s) before \"{{value}}\".",
- unexpectedAfter: "Unexpected space(s) after \"{{value}}\"."
- }
- },
- create(context) {
- const sourceCode = context.getSourceCode();
- const tokensToIgnore = new WeakSet();
- /**
- * Reports a given token if there are not space(s) before the token.
- * @param {Token} token A token to report.
- * @param {RegExp} pattern A pattern of the previous token to check.
- * @returns {void}
- */
- function expectSpaceBefore(token, pattern) {
- const prevToken = sourceCode.getTokenBefore(token);
- if (prevToken &&
- (CHECK_TYPE.test(prevToken.type) || pattern.test(prevToken.value)) &&
- !isOpenParenOfTemplate(prevToken) &&
- !tokensToIgnore.has(prevToken) &&
- astUtils.isTokenOnSameLine(prevToken, token) &&
- !sourceCode.isSpaceBetweenTokens(prevToken, token)
- ) {
- context.report({
- loc: token.loc,
- messageId: "expectedBefore",
- data: token,
- fix(fixer) {
- return fixer.insertTextBefore(token, " ");
- }
- });
- }
- }
- /**
- * Reports a given token if there are space(s) before the token.
- * @param {Token} token A token to report.
- * @param {RegExp} pattern A pattern of the previous token to check.
- * @returns {void}
- */
- function unexpectSpaceBefore(token, pattern) {
- const prevToken = sourceCode.getTokenBefore(token);
- if (prevToken &&
- (CHECK_TYPE.test(prevToken.type) || pattern.test(prevToken.value)) &&
- !isOpenParenOfTemplate(prevToken) &&
- !tokensToIgnore.has(prevToken) &&
- astUtils.isTokenOnSameLine(prevToken, token) &&
- sourceCode.isSpaceBetweenTokens(prevToken, token)
- ) {
- context.report({
- loc: { start: prevToken.loc.end, end: token.loc.start },
- messageId: "unexpectedBefore",
- data: token,
- fix(fixer) {
- return fixer.removeRange([prevToken.range[1], token.range[0]]);
- }
- });
- }
- }
- /**
- * Reports a given token if there are not space(s) after the token.
- * @param {Token} token A token to report.
- * @param {RegExp} pattern A pattern of the next token to check.
- * @returns {void}
- */
- function expectSpaceAfter(token, pattern) {
- const nextToken = sourceCode.getTokenAfter(token);
- if (nextToken &&
- (CHECK_TYPE.test(nextToken.type) || pattern.test(nextToken.value)) &&
- !isCloseParenOfTemplate(nextToken) &&
- !tokensToIgnore.has(nextToken) &&
- astUtils.isTokenOnSameLine(token, nextToken) &&
- !sourceCode.isSpaceBetweenTokens(token, nextToken)
- ) {
- context.report({
- loc: token.loc,
- messageId: "expectedAfter",
- data: token,
- fix(fixer) {
- return fixer.insertTextAfter(token, " ");
- }
- });
- }
- }
- /**
- * Reports a given token if there are space(s) after the token.
- * @param {Token} token A token to report.
- * @param {RegExp} pattern A pattern of the next token to check.
- * @returns {void}
- */
- function unexpectSpaceAfter(token, pattern) {
- const nextToken = sourceCode.getTokenAfter(token);
- if (nextToken &&
- (CHECK_TYPE.test(nextToken.type) || pattern.test(nextToken.value)) &&
- !isCloseParenOfTemplate(nextToken) &&
- !tokensToIgnore.has(nextToken) &&
- astUtils.isTokenOnSameLine(token, nextToken) &&
- sourceCode.isSpaceBetweenTokens(token, nextToken)
- ) {
- context.report({
- loc: { start: token.loc.end, end: nextToken.loc.start },
- messageId: "unexpectedAfter",
- data: token,
- fix(fixer) {
- return fixer.removeRange([token.range[1], nextToken.range[0]]);
- }
- });
- }
- }
- /**
- * Parses the option object and determines check methods for each keyword.
- * @param {Object|undefined} options The option object to parse.
- * @returns {Object} - Normalized option object.
- * Keys are keywords (there are for every keyword).
- * Values are instances of `{"before": function, "after": function}`.
- */
- function parseOptions(options = {}) {
- const before = options.before !== false;
- const after = options.after !== false;
- const defaultValue = {
- before: before ? expectSpaceBefore : unexpectSpaceBefore,
- after: after ? expectSpaceAfter : unexpectSpaceAfter
- };
- const overrides = (options && options.overrides) || {};
- const retv = Object.create(null);
- for (let i = 0; i < KEYS.length; ++i) {
- const key = KEYS[i];
- const override = overrides[key];
- if (override) {
- const thisBefore = ("before" in override) ? override.before : before;
- const thisAfter = ("after" in override) ? override.after : after;
- retv[key] = {
- before: thisBefore ? expectSpaceBefore : unexpectSpaceBefore,
- after: thisAfter ? expectSpaceAfter : unexpectSpaceAfter
- };
- } else {
- retv[key] = defaultValue;
- }
- }
- return retv;
- }
- const checkMethodMap = parseOptions(context.options[0]);
- /**
- * Reports a given token if usage of spacing followed by the token is
- * invalid.
- * @param {Token} token A token to report.
- * @param {RegExp} [pattern] Optional. A pattern of the previous
- * token to check.
- * @returns {void}
- */
- function checkSpacingBefore(token, pattern) {
- checkMethodMap[token.value].before(token, pattern || PREV_TOKEN);
- }
- /**
- * Reports a given token if usage of spacing preceded by the token is
- * invalid.
- * @param {Token} token A token to report.
- * @param {RegExp} [pattern] Optional. A pattern of the next
- * token to check.
- * @returns {void}
- */
- function checkSpacingAfter(token, pattern) {
- checkMethodMap[token.value].after(token, pattern || NEXT_TOKEN);
- }
- /**
- * Reports a given token if usage of spacing around the token is invalid.
- * @param {Token} token A token to report.
- * @returns {void}
- */
- function checkSpacingAround(token) {
- checkSpacingBefore(token);
- checkSpacingAfter(token);
- }
- /**
- * Reports the first token of a given node if the first token is a keyword
- * and usage of spacing around the token is invalid.
- * @param {ASTNode|null} node A node to report.
- * @returns {void}
- */
- function checkSpacingAroundFirstToken(node) {
- const firstToken = node && sourceCode.getFirstToken(node);
- if (firstToken && firstToken.type === "Keyword") {
- checkSpacingAround(firstToken);
- }
- }
- /**
- * Reports the first token of a given node if the first token is a keyword
- * and usage of spacing followed by the token is invalid.
- *
- * This is used for unary operators (e.g. `typeof`), `function`, and `super`.
- * Other rules are handling usage of spacing preceded by those keywords.
- * @param {ASTNode|null} node A node to report.
- * @returns {void}
- */
- function checkSpacingBeforeFirstToken(node) {
- const firstToken = node && sourceCode.getFirstToken(node);
- if (firstToken && firstToken.type === "Keyword") {
- checkSpacingBefore(firstToken);
- }
- }
- /**
- * Reports the previous token of a given node if the token is a keyword and
- * usage of spacing around the token is invalid.
- * @param {ASTNode|null} node A node to report.
- * @returns {void}
- */
- function checkSpacingAroundTokenBefore(node) {
- if (node) {
- const token = sourceCode.getTokenBefore(node, astUtils.isKeywordToken);
- checkSpacingAround(token);
- }
- }
- /**
- * Reports `async` or `function` keywords of a given node if usage of
- * spacing around those keywords is invalid.
- * @param {ASTNode} node A node to report.
- * @returns {void}
- */
- function checkSpacingForFunction(node) {
- const firstToken = node && sourceCode.getFirstToken(node);
- if (firstToken &&
- ((firstToken.type === "Keyword" && firstToken.value === "function") ||
- firstToken.value === "async")
- ) {
- checkSpacingBefore(firstToken);
- }
- }
- /**
- * Reports `class` and `extends` keywords of a given node if usage of
- * spacing around those keywords is invalid.
- * @param {ASTNode} node A node to report.
- * @returns {void}
- */
- function checkSpacingForClass(node) {
- checkSpacingAroundFirstToken(node);
- checkSpacingAroundTokenBefore(node.superClass);
- }
- /**
- * Reports `if` and `else` keywords of a given node if usage of spacing
- * around those keywords is invalid.
- * @param {ASTNode} node A node to report.
- * @returns {void}
- */
- function checkSpacingForIfStatement(node) {
- checkSpacingAroundFirstToken(node);
- checkSpacingAroundTokenBefore(node.alternate);
- }
- /**
- * Reports `try`, `catch`, and `finally` keywords of a given node if usage
- * of spacing around those keywords is invalid.
- * @param {ASTNode} node A node to report.
- * @returns {void}
- */
- function checkSpacingForTryStatement(node) {
- checkSpacingAroundFirstToken(node);
- checkSpacingAroundFirstToken(node.handler);
- checkSpacingAroundTokenBefore(node.finalizer);
- }
- /**
- * Reports `do` and `while` keywords of a given node if usage of spacing
- * around those keywords is invalid.
- * @param {ASTNode} node A node to report.
- * @returns {void}
- */
- function checkSpacingForDoWhileStatement(node) {
- checkSpacingAroundFirstToken(node);
- checkSpacingAroundTokenBefore(node.test);
- }
- /**
- * Reports `for` and `in` keywords of a given node if usage of spacing
- * around those keywords is invalid.
- * @param {ASTNode} node A node to report.
- * @returns {void}
- */
- function checkSpacingForForInStatement(node) {
- checkSpacingAroundFirstToken(node);
- const inToken = sourceCode.getTokenBefore(node.right, astUtils.isNotOpeningParenToken);
- const previousToken = sourceCode.getTokenBefore(inToken);
- if (previousToken.type !== "PrivateIdentifier") {
- checkSpacingBefore(inToken);
- }
- checkSpacingAfter(inToken);
- }
- /**
- * Reports `for` and `of` keywords of a given node if usage of spacing
- * around those keywords is invalid.
- * @param {ASTNode} node A node to report.
- * @returns {void}
- */
- function checkSpacingForForOfStatement(node) {
- if (node.await) {
- checkSpacingBefore(sourceCode.getFirstToken(node, 0));
- checkSpacingAfter(sourceCode.getFirstToken(node, 1));
- } else {
- checkSpacingAroundFirstToken(node);
- }
- const ofToken = sourceCode.getTokenBefore(node.right, astUtils.isNotOpeningParenToken);
- const previousToken = sourceCode.getTokenBefore(ofToken);
- if (previousToken.type !== "PrivateIdentifier") {
- checkSpacingBefore(ofToken);
- }
- checkSpacingAfter(ofToken);
- }
- /**
- * Reports `import`, `export`, `as`, and `from` keywords of a given node if
- * usage of spacing around those keywords is invalid.
- *
- * This rule handles the `*` token in module declarations.
- *
- * import*as A from "./a"; /*error Expected space(s) after "import".
- * error Expected space(s) before "as".
- * @param {ASTNode} node A node to report.
- * @returns {void}
- */
- function checkSpacingForModuleDeclaration(node) {
- const firstToken = sourceCode.getFirstToken(node);
- checkSpacingBefore(firstToken, PREV_TOKEN_M);
- checkSpacingAfter(firstToken, NEXT_TOKEN_M);
- if (node.type === "ExportDefaultDeclaration") {
- checkSpacingAround(sourceCode.getTokenAfter(firstToken));
- }
- if (node.type === "ExportAllDeclaration" && node.exported) {
- const asToken = sourceCode.getTokenBefore(node.exported);
- checkSpacingBefore(asToken, PREV_TOKEN_M);
- checkSpacingAfter(asToken, NEXT_TOKEN_M);
- }
- if (node.source) {
- const fromToken = sourceCode.getTokenBefore(node.source);
- checkSpacingBefore(fromToken, PREV_TOKEN_M);
- checkSpacingAfter(fromToken, NEXT_TOKEN_M);
- }
- }
- /**
- * Reports `as` keyword of a given node if usage of spacing around this
- * keyword is invalid.
- * @param {ASTNode} node An `ImportSpecifier` node to check.
- * @returns {void}
- */
- function checkSpacingForImportSpecifier(node) {
- if (node.imported.range[0] !== node.local.range[0]) {
- const asToken = sourceCode.getTokenBefore(node.local);
- checkSpacingBefore(asToken, PREV_TOKEN_M);
- }
- }
- /**
- * Reports `as` keyword of a given node if usage of spacing around this
- * keyword is invalid.
- * @param {ASTNode} node An `ExportSpecifier` node to check.
- * @returns {void}
- */
- function checkSpacingForExportSpecifier(node) {
- if (node.local.range[0] !== node.exported.range[0]) {
- const asToken = sourceCode.getTokenBefore(node.exported);
- checkSpacingBefore(asToken, PREV_TOKEN_M);
- checkSpacingAfter(asToken, NEXT_TOKEN_M);
- }
- }
- /**
- * Reports `as` keyword of a given node if usage of spacing around this
- * keyword is invalid.
- * @param {ASTNode} node A node to report.
- * @returns {void}
- */
- function checkSpacingForImportNamespaceSpecifier(node) {
- const asToken = sourceCode.getFirstToken(node, 1);
- checkSpacingBefore(asToken, PREV_TOKEN_M);
- }
- /**
- * Reports `static`, `get`, and `set` keywords of a given node if usage of
- * spacing around those keywords is invalid.
- * @param {ASTNode} node A node to report.
- * @throws {Error} If unable to find token get, set, or async beside method name.
- * @returns {void}
- */
- function checkSpacingForProperty(node) {
- if (node.static) {
- checkSpacingAroundFirstToken(node);
- }
- if (node.kind === "get" ||
- node.kind === "set" ||
- (
- (node.method || node.type === "MethodDefinition") &&
- node.value.async
- )
- ) {
- const token = sourceCode.getTokenBefore(
- node.key,
- tok => {
- switch (tok.value) {
- case "get":
- case "set":
- case "async":
- return true;
- default:
- return false;
- }
- }
- );
- if (!token) {
- throw new Error("Failed to find token get, set, or async beside method name");
- }
- checkSpacingAround(token);
- }
- }
- /**
- * Reports `await` keyword of a given node if usage of spacing before
- * this keyword is invalid.
- * @param {ASTNode} node A node to report.
- * @returns {void}
- */
- function checkSpacingForAwaitExpression(node) {
- checkSpacingBefore(sourceCode.getFirstToken(node));
- }
- return {
- // Statements
- DebuggerStatement: checkSpacingAroundFirstToken,
- WithStatement: checkSpacingAroundFirstToken,
- // Statements - Control flow
- BreakStatement: checkSpacingAroundFirstToken,
- ContinueStatement: checkSpacingAroundFirstToken,
- ReturnStatement: checkSpacingAroundFirstToken,
- ThrowStatement: checkSpacingAroundFirstToken,
- TryStatement: checkSpacingForTryStatement,
- // Statements - Choice
- IfStatement: checkSpacingForIfStatement,
- SwitchStatement: checkSpacingAroundFirstToken,
- SwitchCase: checkSpacingAroundFirstToken,
- // Statements - Loops
- DoWhileStatement: checkSpacingForDoWhileStatement,
- ForInStatement: checkSpacingForForInStatement,
- ForOfStatement: checkSpacingForForOfStatement,
- ForStatement: checkSpacingAroundFirstToken,
- WhileStatement: checkSpacingAroundFirstToken,
- // Statements - Declarations
- ClassDeclaration: checkSpacingForClass,
- ExportNamedDeclaration: checkSpacingForModuleDeclaration,
- ExportDefaultDeclaration: checkSpacingForModuleDeclaration,
- ExportAllDeclaration: checkSpacingForModuleDeclaration,
- FunctionDeclaration: checkSpacingForFunction,
- ImportDeclaration: checkSpacingForModuleDeclaration,
- VariableDeclaration: checkSpacingAroundFirstToken,
- // Expressions
- ArrowFunctionExpression: checkSpacingForFunction,
- AwaitExpression: checkSpacingForAwaitExpression,
- ClassExpression: checkSpacingForClass,
- FunctionExpression: checkSpacingForFunction,
- NewExpression: checkSpacingBeforeFirstToken,
- Super: checkSpacingBeforeFirstToken,
- ThisExpression: checkSpacingBeforeFirstToken,
- UnaryExpression: checkSpacingBeforeFirstToken,
- YieldExpression: checkSpacingBeforeFirstToken,
- // Others
- ImportSpecifier: checkSpacingForImportSpecifier,
- ExportSpecifier: checkSpacingForExportSpecifier,
- ImportNamespaceSpecifier: checkSpacingForImportNamespaceSpecifier,
- MethodDefinition: checkSpacingForProperty,
- PropertyDefinition: checkSpacingForProperty,
- StaticBlock: checkSpacingAroundFirstToken,
- Property: checkSpacingForProperty,
- // To avoid conflicts with `space-infix-ops`, e.g. `a > this.b`
- "BinaryExpression[operator='>']"(node) {
- const operatorToken = sourceCode.getTokenBefore(node.right, astUtils.isNotOpeningParenToken);
- tokensToIgnore.add(operatorToken);
- }
- };
- }
- };
|