123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149 |
- /**
- * @fileoverview Rule to flag use constant conditions
- * @author Christian Schulz <http://rndm.de>
- */
- "use strict";
- const { isConstant } = require("./utils/ast-utils");
- //------------------------------------------------------------------------------
- // Helpers
- //------------------------------------------------------------------------------
- //------------------------------------------------------------------------------
- // Rule Definition
- //------------------------------------------------------------------------------
- /** @type {import('../shared/types').Rule} */
- module.exports = {
- meta: {
- type: "problem",
- docs: {
- description: "Disallow constant expressions in conditions",
- recommended: true,
- url: "https://eslint.org/docs/rules/no-constant-condition"
- },
- schema: [
- {
- type: "object",
- properties: {
- checkLoops: {
- type: "boolean",
- default: true
- }
- },
- additionalProperties: false
- }
- ],
- messages: {
- unexpected: "Unexpected constant condition."
- }
- },
- create(context) {
- const options = context.options[0] || {},
- checkLoops = options.checkLoops !== false,
- loopSetStack = [];
- let loopsInCurrentScope = new Set();
- //--------------------------------------------------------------------------
- // Helpers
- //--------------------------------------------------------------------------
- /**
- * Tracks when the given node contains a constant condition.
- * @param {ASTNode} node The AST node to check.
- * @returns {void}
- * @private
- */
- function trackConstantConditionLoop(node) {
- if (node.test && isConstant(context.getScope(), node.test, true)) {
- loopsInCurrentScope.add(node);
- }
- }
- /**
- * Reports when the set contains the given constant condition node
- * @param {ASTNode} node The AST node to check.
- * @returns {void}
- * @private
- */
- function checkConstantConditionLoopInSet(node) {
- if (loopsInCurrentScope.has(node)) {
- loopsInCurrentScope.delete(node);
- context.report({ node: node.test, messageId: "unexpected" });
- }
- }
- /**
- * Reports when the given node contains a constant condition.
- * @param {ASTNode} node The AST node to check.
- * @returns {void}
- * @private
- */
- function reportIfConstant(node) {
- if (node.test && isConstant(context.getScope(), node.test, true)) {
- context.report({ node: node.test, messageId: "unexpected" });
- }
- }
- /**
- * Stores current set of constant loops in loopSetStack temporarily
- * and uses a new set to track constant loops
- * @returns {void}
- * @private
- */
- function enterFunction() {
- loopSetStack.push(loopsInCurrentScope);
- loopsInCurrentScope = new Set();
- }
- /**
- * Reports when the set still contains stored constant conditions
- * @returns {void}
- * @private
- */
- function exitFunction() {
- loopsInCurrentScope = loopSetStack.pop();
- }
- /**
- * Checks node when checkLoops option is enabled
- * @param {ASTNode} node The AST node to check.
- * @returns {void}
- * @private
- */
- function checkLoop(node) {
- if (checkLoops) {
- trackConstantConditionLoop(node);
- }
- }
- //--------------------------------------------------------------------------
- // Public
- //--------------------------------------------------------------------------
- return {
- ConditionalExpression: reportIfConstant,
- IfStatement: reportIfConstant,
- WhileStatement: checkLoop,
- "WhileStatement:exit": checkConstantConditionLoopInSet,
- DoWhileStatement: checkLoop,
- "DoWhileStatement:exit": checkConstantConditionLoopInSet,
- ForStatement: checkLoop,
- "ForStatement > .test": node => checkLoop(node.parent),
- "ForStatement:exit": checkConstantConditionLoopInSet,
- FunctionDeclaration: enterFunction,
- "FunctionDeclaration:exit": exitFunction,
- FunctionExpression: enterFunction,
- "FunctionExpression:exit": exitFunction,
- YieldExpression: () => loopsInCurrentScope.clear()
- };
- }
- };
|